fix(datepicker): inconsistent focus restoration timing in touchUi mode #17732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
|
@crisbeto Sorry, looks like I forgot to review this one. LGTM as long as you're able to rebase it |
mmalerba
approved these changes
Mar 5, 2020
`MatDatepicker` has focus restoration which happens (almost) synchronously, whereas `MatDialog` restores focus asynchronously when the animation is finished. This means that in `touchUi` mode focus ends up being restored both by the datepicker and the dialog within a 150ms window. The problem is that if the consumer of `MatDatepicker` decides to move focus inside the `closed` event, it'll be ovewritten by the dialog 150ms later. These changes disable the dialog's focus restoration because it's unnecessary. Fixes angular#17560.
crisbeto
force-pushed
the
17560/datepicker-dialog-focus-restoration
branch
from
34a5997
to
a91d84d
Compare
|
Rebased. |
jelbourn
pushed a commit
that referenced
this pull request
Apr 23, 2020
#17732) `MatDatepicker` has focus restoration which happens (almost) synchronously, whereas `MatDialog` restores focus asynchronously when the animation is finished. This means that in `touchUi` mode focus ends up being restored both by the datepicker and the dialog within a 150ms window. The problem is that if the consumer of `MatDatepicker` decides to move focus inside the `closed` event, it'll be ovewritten by the dialog 150ms later. These changes disable the dialog's focus restoration because it's unnecessary. Fixes #17560.
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
angular#17732) `MatDatepicker` has focus restoration which happens (almost) synchronously, whereas `MatDialog` restores focus asynchronously when the animation is finished. This means that in `touchUi` mode focus ends up being restored both by the datepicker and the dialog within a 150ms window. The problem is that if the consumer of `MatDatepicker` decides to move focus inside the `closed` event, it'll be ovewritten by the dialog 150ms later. These changes disable the dialog's focus restoration because it's unnecessary. Fixes angular#17560.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatDatepickerhas focus restoration which happens (almost) synchronously, whereasMatDialogrestores focus asynchronously when the animation is finished. This means that intouchUimode focus ends up being restored both by the datepicker and the dialog within a 150ms window. The problem is that if the consumer ofMatDatepickerdecides to move focus inside theclosedevent, it'll be ovewritten by the dialog 150ms later. These changes disable the dialog's focus restoration because it's unnecessary.Fixes #17560.