fix(material-experimental/mdc-chips): not disabling all animations when animations are disabled #18440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
approved these changes
Feb 9, 2020
|
@crisbeto needs rebase |
|
Rebased. |
crisbeto
force-pushed
the
mdc-chips-animation-noopable
branch
from
ef972ad
to
161f78b
Compare
crisbeto
force-pushed
the
mdc-chips-animation-noopable
branch
from
161f78b
to
c17f0e0
Compare
…en animations are disabled Currently the MDC chip only disables the removal animation when all animations are disabled. These changes make it so that the rest of the animations are disabled as well.
crisbeto
force-pushed
the
mdc-chips-animation-noopable
branch
from
c17f0e0
to
7b57503
Compare
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
…en animations are disabled (angular#18440) Currently the MDC chip only disables the removal animation when all animations are disabled. These changes make it so that the rest of the animations are disabled as well.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the MDC chip only disables the removal animation when all animations are disabled. These changes make it so that the rest of the animations are disabled as well.