Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stepper): parent stepper picking up steps from child stepper #18458

Merged
merged 1 commit into from Aug 12, 2020
Merged

fix(stepper): parent stepper picking up steps from child stepper #18458

merged 1 commit into from Aug 12, 2020

Conversation

crisbeto
Copy link
Member

When we initially made some changes to handle Ivy, we made an assumption that people wouldn't nest steppers so we took one shortcut. It looks like that assumption wasn't correct so these changes make it possible to properly nest steppers again.

Fixes #18448.

@crisbeto
fix(stepper): parent stepper picking up steps from child stepper
0a7979c 
When we initially made some changes to handle Ivy, we made an assumption that people wouldn't nest steppers so we took one shortcut. It looks like that assumption wasn't correct so these changes make it possible to properly nest steppers again.

Fixes angular#18448.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Feb 10, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 10, 2020
jelbourn
jelbourn approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 10, 2020
@mhosman
Copy link

mhosman commented Feb 24, 2020

There is some news in this one? Mi app is broken. Thank you very much!

@mmalerba
Copy link
Contributor

It looks like there are 5 failing targets in google3 that need investigation before this can be merged

@crisbeto crisbeto mentioned this pull request Mar 8, 2020
Closed
@mhosman
Copy link

mhosman commented Apr 2, 2020

Same here! Any update?

@mmalerba
Copy link
Contributor

mmalerba commented Apr 2, 2020

There were some failing unit tests when this was presubmitted against Google's codebase. A member of the team will need to investigate before it can be merged.

@mhosman
Copy link

mhosman commented Apr 15, 2020 •
edited

Sorry but this is gonna happen?

@przemo101
Copy link

Is anyone know when the fix is going to appear in angular 9 ?

@lukaesch
Copy link

lukaesch commented May 24, 2020 •
edited

Thanks for writing the fix. When is this going to be released and is there a workaround available until then?

@qazarr
Copy link

qazarr commented Jun 18, 2020

Please, can someone merge this PR? I am also waiting for this fix

@jelbourn jelbourn added this to PRs in P2 PRs Jul 9, 2020
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@LotfiMEZIANI
Copy link

I'm waiting -_- fot this...

@andrewseguin andrewseguin merged commit 9d309f7 into angular:master Aug 12, 2020
P2 PRs automation moved this from PRs to Done Aug 12, 2020
andrewseguin pushed a commit that referenced this pull request Aug 12, 2020
@crisbeto @andrewseguin
fix(stepper): parent stepper picking up steps from child stepper (#18458
22d645c 
)

When we initially made some changes to handle Ivy, we made an assumption that people wouldn't nest steppers so we took one shortcut. It looks like that assumption wasn't correct so these changes make it possible to properly nest steppers again.

Fixes #18448.

(cherry picked from commit 9d309f7)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
P2 PRs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to create nested mat-stepper's since 9.0.0
10 participants
@crisbeto @mhosman @mmalerba @przemo101 @lukaesch @qazarr @LotfiMEZIANI @jelbourn @googlebot @andrewseguin