feat(form-field): expose label content element id for custom controls #18528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
refactor/mdc-form-field-label
branch
from
9c84902
to
0d4326f
Compare
crisbeto
reviewed
Feb 18, 2020
devversion
force-pushed
the
refactor/mdc-form-field-label
branch
3 times, most recently
from
c5fa00e
to
e3101ce
Compare
devversion
commented
Feb 26, 2020
| @@ -23,7 +23,7 @@ class MyTel { | |||
| @Component({ | |||
| selector: 'example-tel-input', | |||
| template: ` | |||
| <div [formGroup]="parts"> | |||
| <div role="group" [formGroup]="parts"> | |||
There was a problem hiding this comment.
FYI: This is the recommended pattern for grouping multiple inputs: https://www.w3.org/TR/WCAG20-TECHS/ARIA17.html
There was a problem hiding this comment.
@crisbeto do we have this on date-range-input?
|
@mmalerba Addressed your feedback. Thanks! |
devversion
force-pushed
the
refactor/mdc-form-field-label
branch
from
e3101ce
to
307f446
Compare
devversion
force-pushed
the
refactor/mdc-form-field-label
branch
from
307f446
to
db1fafe
Compare
Currently, the form-field always creates a label element as sibling to projected form-field controls. For native controls, the label is associated with the controls using the `for` attribute. This doesn't work for custom controls which might not be based on native controls. e.g. the `mat-select`. In those cases, the appropriate aria attributes need to be applied with `aria-labelledby` that refers to the label content element. Since this is a common pattern for custom controls that don't use native controls, we need to expose the element id for the label content. Currently we already do this for the select, but just prefixed it with an underscore. This denotes it as private API while there is obviously a use-case for exposing this publicly. Best example is how the select _needs_ it.
Improves the accessibility for the control that is built as part of the custom form-field control guide.
devversion
force-pushed
the
refactor/mdc-form-field-label
branch
from
db1fafe
to
83d363e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the form-field always creates a label element as sibling
to projected form-field controls. For native controls, the label is
associated with the controls using the
forattribute.This doesn't work for custom controls which might not be based
on native controls. e.g. the
mat-select. In those cases, theappropriate aria attributes need to be applied with
aria-labelledbythat refers to the label content element.
Since this is a common pattern for custom controls that don't use
native controls, we need to expose the element id for the label content.
Currently we already do this for the select, but just prefixed it with
an underscore. This denotes it as private API while there is obviously a
use-case for exposing this publicly. Best example is how the select needs it.
Note: If we decide to go with that change, the target is usually
minor, but it might be worth checking if we could get it intomasterearlier for our MDC form-field changes.