perf(icon): avoid unnecessarily parsing icon sets #18654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
18644/icon-parse-optimization
branch
from
556d09a
to
32f07f1
Compare
jelbourn
reviewed
Mar 2, 2020
| } | ||
|
|
||
| /** Icon configuration whose content has already been loaded. */ | ||
| type LoadedSvgIconConfig = SvgIconConfig & {svgText: string}; |
There was a problem hiding this comment.
It's cool to see how techniques like this develop and apply to code written when we were all first starting to use TypeScript.
crisbeto
force-pushed
the
18644/icon-parse-optimization
branch
from
32f07f1
to
143dd01
Compare
|
I've addressed the feedback @jelbourn. |
|
@crisbeto Thanks for the quick fix! |
jelbourn
added
perf
Some internal refactoring to improve the performance of the icon registry by avoiding unnecessary work:
* When an icon set is registered as a string literal, we parse it immediately into an SVG element. This is inefficient since the set may not be required immediately. These changes make it so that we store the SVG text and we only parse it when it's required.
* When an icon is requested, we try to find it in all any of the icon sets which requires us to parse them since we don't know which one is supposed to have it. These changes add an inexpensive `indexOf` check before parsing so that we can quickly rule out the sets that absolutely can't have the icon. The check won't exclude 100% of the unnecessary parsing, but it should help with the majority. Once this is in we could make it slightly smarter by doing something like `svgText.indexOf(`id="${iconName}"`)`, but that's a bit more risky.
Fixes angular#18644.
mmalerba
force-pushed
the
18644/icon-parse-optimization
branch
from
143dd01
to
f4bfa84
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Aug 13, 2020
Some internal refactoring to improve the performance of the icon registry by avoiding unnecessary work:
* When an icon set is registered as a string literal, we parse it immediately into an SVG element. This is inefficient since the set may not be required immediately. These changes make it so that we store the SVG text and we only parse it when it's required.
* When an icon is requested, we try to find it in all any of the icon sets which requires us to parse them since we don't know which one is supposed to have it. These changes add an inexpensive `indexOf` check before parsing so that we can quickly rule out the sets that absolutely can't have the icon. The check won't exclude 100% of the unnecessary parsing, but it should help with the majority. Once this is in we could make it slightly smarter by doing something like `svgText.indexOf(`id="${iconName}"`)`, but that's a bit more risky.
Fixes #18644.
(cherry picked from commit 5526ab9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some internal refactoring to improve the performance of the icon registry by avoiding unnecessary work:
indexOfcheck before parsing so that we can quickly rule out the sets that absolutely can't have the icon. The check won't exclude 100% of the unnecessary parsing, but it should help with the majority. Once this is in we could make it slightly smarter by doing something likesvgText.indexOf('id="${iconName}"'), but that's a bit more risky.Fixes #18644.