Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(datepicker): add tests for the date range picker #18884

Merged
merged 1 commit into from Mar 27, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 22, 2020

Adds more tests for the date range picker functionality. These cover the logic for displaying and selecting the range, as well as the integration between the range input, range picker and calendar.

Also fixes a couple of smaller issues that were revealed while I was writing the tests.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe labels Mar 22, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner March 22, 2020 15:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 22, 2020
Adds more tests for the date range picker functionality. These cover the logic for displaying and selecting the range, as well as the integration between the range input, range picker and calendar.

Also fixes a couple of smaller issues that were revealed while I was writing the tests.
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 27, 2020
@crisbeto crisbeto merged commit e9f9cdd into angular:date-range Mar 27, 2020
crisbeto added a commit that referenced this pull request Mar 31, 2020
Adds more tests for the date range picker functionality. These cover the logic for displaying and selecting the range, as well as the integration between the range input, range picker and calendar.

Also fixes a couple of smaller issues that were revealed while I was writing the tests.
crisbeto added a commit that referenced this pull request Apr 9, 2020
Adds more tests for the date range picker functionality. These cover the logic for displaying and selecting the range, as well as the integration between the range input, range picker and calendar.

Also fixes a couple of smaller issues that were revealed while I was writing the tests.
crisbeto added a commit that referenced this pull request Apr 14, 2020
Adds more tests for the date range picker functionality. These cover the logic for displaying and selecting the range, as well as the integration between the range input, range picker and calendar.

Also fixes a couple of smaller issues that were revealed while I was writing the tests.
crisbeto added a commit that referenced this pull request Apr 17, 2020
Adds more tests for the date range picker functionality. These cover the logic for displaying and selecting the range, as well as the integration between the range input, range picker and calendar.

Also fixes a couple of smaller issues that were revealed while I was writing the tests.
crisbeto added a commit that referenced this pull request Apr 20, 2020
Adds more tests for the date range picker functionality. These cover the logic for displaying and selecting the range, as well as the integration between the range input, range picker and calendar.

Also fixes a couple of smaller issues that were revealed while I was writing the tests.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants