Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): incorrect dialog state for close animation #19034

Merged
merged 1 commit into from
Apr 20, 2020
Merged

fix(dialog): incorrect dialog state for close animation #19034

merged 1 commit into from
Apr 20, 2020

Conversation

devversion
Copy link
Member

The dialog currently sets its state to closed even when the close
animation is still in progress. This happens due to a misplaced state
update assignment.

@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 9, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 9, 2020
@devversion devversion force-pushed the fix/dialog-state-incorrect-mid-closing-animation branch from cf54d65 to 18a66a3 Compare April 9, 2020 18:39
@devversion devversion assigned mmalerba and unassigned jelbourn Apr 9, 2020
crisbeto
crisbeto approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from the comment on the test.

src/material/dialog/dialog.spec.ts Outdated Show resolved Hide resolved
@crisbeto crisbeto added the lgtm label Apr 10, 2020
@devversion
fix(dialog): incorrect dialog state for close animation
fc31b99 
The dialog currently sets its state to `CLOSED` if the
close animation is still in progress. This happens due to a
misplaced state update assignment.
@devversion devversion force-pushed the fix/dialog-state-incorrect-mid-closing-animation branch from 18a66a3 to fc31b99 Compare April 10, 2020 08:28
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Apr 10, 2020
mmalerba
mmalerba approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This feels like the kind of thing that could break tests and be difficult to get in, but oh well, let's at least try

@jelbourn jelbourn merged commit b612fc4 into angular:master Apr 20, 2020
jelbourn pushed a commit that referenced this pull request Apr 20, 2020
@devversion @jelbourn
fix(dialog): incorrect dialog state for close animation (#19034)
fd0217d 
The dialog currently sets its state to `CLOSED` if the
close animation is still in progress. This happens due to a
misplaced state update assignment.

(cherry picked from commit b612fc4)
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@devversion @soro-google
fix(dialog): incorrect dialog state for close animation (angular#19034)
9d2cf0b 
The dialog currently sets its state to `CLOSED` if the
close animation is still in progress. This happens due to a
misplaced state update assignment.
@snyk-bot snyk-bot mentioned this pull request May 3, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@crisbeto crisbeto

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@devversion @crisbeto @mmalerba @jelbourn @googlebot