fix(material-experimental/mdc-form-field): missing styles for native select control #19140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…select controls With the initial implementation of the MDC-based form-field we added support for `matInput`, but it looks like the styles for the native select were missing. This currently means that the select might show undesired focus indiciation or that the select is slightly inset due to the native appearance.
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
mmalerba
reviewed
Apr 22, 2020
jelbourn
pushed a commit
that referenced
this pull request
Apr 23, 2020
…select controls (#19140) With the initial implementation of the MDC-based form-field we added support for `matInput`, but it looks like the styles for the native select were missing. This currently means that the select might show undesired focus indiciation or that the select is slightly inset due to the native appearance.
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
…select controls (angular#19140) With the initial implementation of the MDC-based form-field we added support for `matInput`, but it looks like the styles for the native select were missing. This currently means that the select might show undesired focus indiciation or that the select is slightly inset due to the native appearance.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the initial implementation of the MDC-based form-field we
added support for
matInput, but it looks like the stylesfor the native select were missing. This currently means that
the select might show undesired focus indiciation or that
the select is slightly inset due to the native appearance.
Note: Styles are a subset of the ones from the non-MDC form-field (only the needed ones). I'm unhappy about more CSS in the form-field but this one is inevitable since our form-field does not only support input/textarea, but also native select controls.