Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components-examples): rename example component #19142

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Apr 22, 2020

Rename example component (previous nested-menu to menu-nested) to be consistent with other menu examples. This facilitates autoloading examples onto the materials documentation site.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 22, 2020
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 22, 2020
@mmalerba mmalerba removed docs This issue is related to documentation target: patch This PR is targeted for the next patch release labels Apr 22, 2020
@crisbeto crisbeto added target: development-branch docs This issue is related to documentation target: patch This PR is targeted for the next patch release and removed target: development-branch labels Apr 22, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yeah, pelase open one to change the documentation-items manually so it continues to work while you're working on the other PR

@jelbourn jelbourn merged commit d129692 into angular:master Apr 23, 2020
jelbourn pushed a commit that referenced this pull request Apr 23, 2020
…onvention for autoloading in docs (#19142)

Co-authored-by: Annie Wang <annieyw@google.com>
@annieyw annieyw deleted the rename branch April 23, 2020 16:58
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
…onvention for autoloading in docs (angular#19142)

Co-authored-by: Annie Wang <annieyw@google.com>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants