Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(checkbox): high contrast focus indication not working #19488

Merged
merged 1 commit into from Jun 5, 2020
Merged

fix(checkbox): high contrast focus indication not working #19488

merged 1 commit into from Jun 5, 2020

Conversation

crisbeto
Copy link
Member

A while ago the cdk-high-contrast mixin was changed from using a media query to a class. This seems to have broken one of the selectors that render the focus indication.

Fixes #19443.

@crisbeto
fix(checkbox): high contrast focus indication not working
03e0b09 
A while ago the `cdk-high-contrast` mixin was changed from using a media query to a class. This seems to have broken one of the selectors that render the focus indication.

Fixes angular#19443.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels May 30, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 30, 2020
devversion
devversion approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels May 30, 2020
jelbourn
jelbourn approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit a95da92 into angular:master Jun 5, 2020
jelbourn pushed a commit that referenced this pull request Jun 5, 2020
@crisbeto @jelbourn
fix(checkbox): high contrast focus indication not working (#19488)
6094a67 
A while ago the `cdk-high-contrast` mixin was changed from using a media query to a class. This seems to have broken one of the selectors that render the focus indication.

Fixes #19443.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checkbox: high contrast focus indicator not visible
4 participants
@crisbeto @jelbourn @devversion @googlebot