Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(tooltip): Hook up to pointer leave events when pointer enter events fire #19777

Merged
merged 4 commits into from Jul 28, 2020
Merged

perf(tooltip): Hook up to pointer leave events when pointer enter events fire #19777

merged 4 commits into from Jul 28, 2020

Conversation

kseamon
Copy link
Collaborator

@kseamon kseamon commented Jun 26, 2020

Rather than greedily at startup.

This builds on top of #19764 so should get merged afterwards.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 26, 2020
@kseamon kseamon changed the title perf(tooltip): Hoop up to pointer leave events when pointer enter events fire perf(tooltip): Hook up to pointer leave events when pointer enter events fire Jun 26, 2020
jelbourn
jelbourn reviewed Jun 26, 2020
View reviewed changes
src/material/tooltip/tooltip.ts Outdated Show resolved Hide resolved
src/material/tooltip/tooltip.ts Outdated Show resolved Hide resolved
@kseamon kseamon mentioned this pull request Jun 26, 2020
Merged
@kseamon kseamon requested a review from devversion as a code owner June 26, 2020 20:30
jelbourn
jelbourn approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/material/tooltip/tooltip.ts Show resolved Hide resolved
@jelbourn jelbourn added lgtm blocked This issue is blocked by some external factor, such as a prerequisite PR target: patch This PR is targeted for the next patch release labels Jun 30, 2020
@kseamon
Copy link
Collaborator Author

kseamon commented Jul 1, 2020

Re: Map([...m1, ...m2])

Not that we're debating it really, but that'd be slower yet and add GC pressure for no significant change in readability.

@kseamon kseamon removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Jul 15, 2020
@kseamon kseamon added the G This is is related to a Google internal issue label Jul 15, 2020
@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jul 16, 2020
@jelbourn jelbourn added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jul 16, 2020
jelbourn
jelbourn approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker perf This issue is related to performance labels Jul 16, 2020
@jelbourn jelbourn merged commit 04b7523 into angular:master Jul 28, 2020
jelbourn pushed a commit that referenced this pull request Jul 28, 2020
@kseamon @jelbourn
perf(tooltip): Hook up to pointer leave events when pointer enter eve…
3c9a4ac 
…nts fire (#19777)

Only adds listeners for leave events _after_ an enter event occurs, rather than eagerly.

(cherry picked from commit 04b7523)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue perf This issue is related to performance target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kseamon @jelbourn @crisbeto @googlebot