Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(table): Do column name string interpolation once per column instead of once per cell #19801

Merged
merged 7 commits into from Aug 5, 2020
Merged

perf(table): Do column name string interpolation once per column instead of once per cell #19801

merged 7 commits into from Aug 5, 2020

Conversation

kseamon
Copy link
Collaborator

@kseamon kseamon commented Jun 29, 2020

Should be a slight code size improvement as well.

This is a non-breaking subset of #19743, which will have to wait for the next major version.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 29, 2020
jelbourn
jelbourn approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added G This is is related to a Google internal issue lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 29, 2020
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@mmalerba mmalerba merged commit bf953e9 into angular:master Aug 5, 2020
mmalerba pushed a commit that referenced this pull request Aug 5, 2020
@kseamon @mmalerba
perf(table): Do column name string interpolation once per column inst…
19dd8bb 
…ead of once per cell (#19801)

* perf(table): Use only one column classname and do string interpolation once per column

* missed a couple

* lint

* update api

* For now, just share the css classname across cells, but keep same behavior.

* lint

* update api

(cherry picked from commit bf953e9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kseamon @jelbourn @googlebot @mmalerba