Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tabindex inputs not supporting coercion #20037

Merged
merged 1 commit into from
Jul 24, 2020
Merged

fix: tabindex inputs not supporting coercion #20037

merged 1 commit into from
Jul 24, 2020

Conversation

crisbeto
Copy link
Member

All the components that were implementing the HasTabIndex input weren't allowing coercion.

Fixes #20026.

@crisbeto
fix: tabindex inputs not supporting coercion
e16b902 
All the components that were implementing the `HasTabIndex` input weren't allowing coercion.

Fixes angular#20026.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 18, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 18, 2020
@devversion
Copy link
Member

When I look at the corresponding issue for this PR, it seems to me that the common pattern for static tabindex values should be to set the tabindex attribute (instead of the tabIndex property). I think we did that in a couple of components using @Attribute, but probably not consistent and the use of a basic input (through the mixin) is easier to maintain/consume by users.

jelbourn
jelbourn approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 21, 2020
@wagnermaciel wagnermaciel merged commit 333e609 into angular:master Jul 24, 2020
wagnermaciel pushed a commit that referenced this pull request Jul 24, 2020
@crisbeto @wagnermaciel
fix: tabindex inputs not supporting coercion (#20037)
ec5986c 
All the components that were implementing the `HasTabIndex` input weren't allowing coercion.

Fixes #20026.

(cherry picked from commit 333e609)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatChip tabIndex doesn't accept static values
5 participants
@crisbeto @devversion @jelbourn @googlebot @wagnermaciel