Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/testing): emit pointer events on hover and mouseAway #20098

Merged
merged 1 commit into from Jul 28, 2020

Conversation

crisbeto
Copy link
Member

In 9cd1891 pointer event simulation was added to UnitTestElement.click to closer simulate the events that happen inside the browser. These changes expand the coverage to the hover and mouseAway methods since they can dispatch pointer events too.

In 9cd1891 pointer event simulation was added to `UnitTestElement.click` to closer simulate the events that happen inside the browser. These changes expand the coverage to the `hover` and `mouseAway` methods since they can dispatch pointer events too.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 26, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 26, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 27, 2020
@jelbourn jelbourn merged commit a5274a9 into angular:master Jul 28, 2020
jelbourn pushed a commit that referenced this pull request Jul 28, 2020
In 9cd1891 pointer event simulation was added to `UnitTestElement.click` to closer simulate the events that happen inside the browser. These changes expand the coverage to the `hover` and `mouseAway` methods since they can dispatch pointer events too.

(cherry picked from commit a5274a9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants