fix(cdk-experimental/menu): ensure menu is closed out when clicking on an inline menu item #20241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Issuing as a draft since the class naming convention is also shared in #20234 and may change depending on feedback there. Accepting feedback on tests and other aspects in the meantime. |
jelbourn
added
merge safe
target: minor
|
CAn add "merge ready" when ready |
andy9775
force-pushed
the
cdk-menu-fix-menu-close
branch
from
7209b3b
to
f436d6e
Compare
…n an inline menu item Fixes an issue where clicking an item in an inline menu prevents any open popout menus from closing out.
andy9775
force-pushed
the
cdk-menu-fix-menu-close
branch
from
f436d6e
to
dedf046
Compare
teflonwaffles
approved these changes
Aug 10, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where clicking an item in an inline menu prevents any open popout menus from closing
out.