Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table): incorrect padding for single-cell rows in rtl #20266

Merged
merged 1 commit into from Aug 19, 2020
Merged

fix(table): incorrect padding for single-cell rows in rtl #20266

merged 1 commit into from Aug 19, 2020

Conversation

crisbeto
Copy link
Member

The styles that reset the padding in RTL shouldn't apply to single-cell rows. Also moves a bit of code around so we don't have to repeat top-level selectors as much.

Fixes #20265.

@crisbeto
fix(table): incorrect padding for single-cell rows in rtl
b064b04 
The styles that reset the padding in RTL shouldn't apply to single-cell rows. Also moves a bit of code around so we don't have to repeat top-level selectors as much.

Fixes angular#20265.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release labels Aug 11, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 11, 2020
@crisbeto
Copy link
Member Author

Caretaker note: this increases the specificity of a couple of selectors. We should re-evaluate the approach if it ends up breaking screenshot tests.

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Aug 11, 2020
@wagnermaciel wagnermaciel merged commit 1f6b90c into angular:master Aug 19, 2020
wagnermaciel pushed a commit that referenced this pull request Aug 19, 2020
@crisbeto @wagnermaciel
fix(table): incorrect padding for single-cell rows in rtl (#20266)
89b05a8 
The styles that reset the padding in RTL shouldn't apply to single-cell rows. Also moves a bit of code around so we don't have to repeat top-level selectors as much.

Fixes #20265.

(cherry picked from commit 1f6b90c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Angular Material Table): Single mat-cell in a row has incorrect padding in RTL
4 participants
@crisbeto @andrewseguin @googlebot @wagnermaciel