Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox dev app #20276

Merged
merged 26 commits into from Aug 13, 2020
Merged

Combobox dev app #20276

merged 26 commits into from Aug 13, 2020

Conversation

nielsr98
Copy link
Contributor

Added simple combobox example to dev app and added a function to set the text of the combobox if the value is a string.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 12, 2020
@nielsr98 nielsr98 added target: minor This PR is targeted for the next minor release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Aug 12, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 12, 2020
@nielsr98
build: Added required files to listbox directory.
6b43b7c
@nielsr98
build: added listbox option directive and renamed listbox directive f…
c89cb4d 
…iles.
@nielsr98
build: Added required files to listbox directory.
fd65034
@nielsr98
build: added listbox option directive and renamed listbox directive f…
33032f9 
…iles.
@nielsr98
build: Added required files to listbox directory.
9d9fdcf
@nielsr98
build: added listbox option directive and renamed listbox directive f…
357bfa7 
…iles.
@nielsr98
build: Added required files to listbox directory.
df41e8b
@nielsr98
build: added listbox option directive and renamed listbox directive f…
081e970 
…iles.
@nielsr98
feat(dev-app/listbox): added cdk listbox example to the dev-app.
89ff036
@nielsr98
fix(listbox): removed duplicate dep in dev-app build file.
6fad24e
@nielsr98
fix(listbox): deleted unused files.
7b0e864
@nielsr98
feat(combobox): added all basic features to combobox and combobox pan…
c4c72e6 
…el, and some tests.
@nielsr98
fix(combobox): fixed import path for combobox panel.
b6be785
@nielsr98
refactor(combobox): changed names and made coerceOpenActionProperty s…
e496bc3 
…impler for this PR.
@nielsr98
fix(combobox): updated syntax for casting.
93966d9
@nielsr98
refactor(combobox): changed casting syntax back.
9242faf
@nielsr98
fix(combobox): fixed trailing whitespace.
cfc9af5
@nielsr98
feat(combobox): added combobox to dev app.
7c1c731
@nielsr98
refactor(combobox): removed commented out import and fixed the name o…
3b89ac4 
…f an input reference in the combobox spec.
@nielsr98
fix(combobox): removed duplicate import.
e13b571
jelbourn
jelbourn reviewed Aug 12, 2020
View reviewed changes
src/cdk-experimental/combobox/combobox.ts Show resolved Hide resolved
src/dev-app/cdk-experimental-combobox/cdk-combobox-demo-module.ts Outdated
Comment on lines 17 to 20
imports: [
CdkComboboxModule,
CommonModule,
RouterModule.forChild([{path: '', component: CdkComboboxDemo}]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
imports: [
CdkComboboxModule,
CommonModule,
RouterModule.forChild([{path: '', component: CdkComboboxDemo}]),
imports: [
CdkComboboxModule,
CommonModule,
RouterModule.forChild([{path: '', component: CdkComboboxDemo}]),

src/dev-app/cdk-experimental-combobox/panel-content.ts
'[id]': 'dialogId'
}
})
export class PanelContent<V> implements OnInit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for testing, or do you intend for this to be the ultimate API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this directive is just for testing/demo purposes. It is the directive that is applied to the custom panel content the user wishes to use, like their own dialog. It handles registering the content with the panel. I did realize it was doing more than I needed it to do in this example so I've toned it down.

jelbourn
jelbourn approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe labels Aug 12, 2020
@andrewseguin andrewseguin added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Aug 13, 2020
@andrewseguin andrewseguin merged commit f718821 into angular:master Aug 13, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nielsr98 @jelbourn @googlebot @andrewseguin