feat(material-experimental/menubar): update the dev-app to include a fake mat-menu #20365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
andy9775
force-pushed
the
mat-experimental-menubar-mocks
branch
2 times, most recently
from
40458d5
to
49eab6e
Compare
jelbourn
approved these changes
Aug 19, 2020
andy9775
force-pushed
the
mat-experimental-menubar-mocks
branch
from
49eab6e
to
bc678fc
Compare
andy9775
changed the title
andy9775
force-pushed
the
mat-experimental-menubar-mocks
branch
3 times, most recently
from
44e9e8d
to
01caf3f
Compare
…fake mat-menu Fake mat-menu and mat-menu-item in the dev-app in order to aid in development of mat-menubar. Once mat-menu extends CdkMenu, the fakses should be removed.
andy9775
force-pushed
the
mat-experimental-menubar-mocks
branch
from
01caf3f
to
db7bd44
Compare
|
@jelbourn feedback should be addressed |
jelbourn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fake mat-menu and mat-menu-item in the dev-app in order to aid in development of mat-menubar.
Once mat-menu extends CdkMenu, the fakses should be removed.