fix(menu): open animation not working on repeat opens #20382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be a remnant of the old menu animation. Previously when a menu was opened, we had a two step animation: scale and fade in the panel and then fade in the items a little bit later. When the latest Material design spec update was implemented, the animation was simplified to a fade in and scale only, however some of the metadata doesn't seem to have been cleaned up which is causing an issue where we set an `opacity` on the items when we close the panel for the first time, but there's nothing resetting it the next time around which ends up causing the entire animation to be skipped. Fixes angular#20379.
crisbeto
added
P2
googlebot
added
the
cla: yes
andrewseguin
pushed a commit
that referenced
this pull request
Sep 9, 2020
This seems to be a remnant of the old menu animation. Previously when a menu was opened, we had a two step animation: scale and fade in the panel and then fade in the items a little bit later. When the latest Material design spec update was implemented, the animation was simplified to a fade in and scale only, however some of the metadata doesn't seem to have been cleaned up which is causing an issue where we set an `opacity` on the items when we close the panel for the first time, but there's nothing resetting it the next time around which ends up causing the entire animation to be skipped. Fixes #20379. (cherry picked from commit ea628c9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a remnant of the old menu animation. Previously when a menu was opened, we had a two step animation: scale and fade in the panel and then fade in the items a little bit later.
When the latest Material design spec update was implemented, the animation was simplified to a fade in and scale only, however some of the metadata doesn't seem to have been cleaned up which is causing an issue where we set an
opacityon the items when we close the panel for the first time, but there's nothing resetting it the next time around which ends up causing the entire animation to be skipped.Fixes #20379.
Note: setting this as a P2, because it's a regression.