perf(drag-drop): bind fewer touchmove listeners #20404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On touch devices we have to bind the `touchmove` event before dragging has started, because iOS Safari won't allow us to call `preventDefault` on it otherwise. We also bind another `touchmove` listener once dragging starts which is what is used for moving the elements around on the screen. These changes remove the dynamically-added `touchmove` listener and use the persistent one for everything instead.
crisbeto
added
P3
googlebot
added
the
cla: yes
wagnermaciel
pushed a commit
that referenced
this pull request
Sep 16, 2020
On touch devices we have to bind the `touchmove` event before dragging has started, because iOS Safari won't allow us to call `preventDefault` on it otherwise. We also bind another `touchmove` listener once dragging starts which is what is used for moving the elements around on the screen. These changes remove the dynamically-added `touchmove` listener and use the persistent one for everything instead. (cherry picked from commit 2b1d84e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On touch devices we have to bind the
touchmoveevent before dragging has started, because iOS Safari won't allow us to callpreventDefaulton it otherwise. We also bind anothertouchmovelistener once dragging starts which is what is used for moving the elements around on the screen.These changes remove the dynamically-added
touchmovelistener and use the persistent one for everything instead.