Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/tree): remove CdkTreeNodeDef from CdkTreeModules providers #20491

Merged
merged 1 commit into from
Sep 5, 2020
Merged

fix(cdk/tree): remove CdkTreeNodeDef from CdkTreeModules providers #20491

merged 1 commit into from
Sep 5, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Sep 3, 2020

CdkTreeNodeDef is a directive and should not be included in the providers

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2020
mmalerba
mmalerba approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 3, 2020
@mmalerba mmalerba mentioned this pull request Sep 3, 2020
Merged
@mmalerba mmalerba added G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround labels Sep 3, 2020
@mmalerba mmalerba merged commit a45efb8 into angular:master Sep 5, 2020
mmalerba pushed a commit that referenced this pull request Sep 5, 2020
@annieyw @mmalerba
fix(cdk/tree): remove CdkTreeNodeDef from CdkTreeModules providers (#…
1887f80 
…20491)

(cherry picked from commit a45efb8)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 6, 2020
@annieyw annieyw deleted the remove-from-prodivers branch November 9, 2020 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@annieyw @mmalerba @googlebot