Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/tree): remove FocusMonitor from CdkTreeModule providers #20493

Merged
merged 1 commit into from
Sep 16, 2020
Merged

fix(cdk/tree): remove FocusMonitor from CdkTreeModule providers #20493

merged 1 commit into from
Sep 16, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Sep 3, 2020

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2020
jelbourn
jelbourn approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 3, 2020
@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Sep 3, 2020
@mmalerba
Copy link
Contributor

mmalerba commented Sep 3, 2020

This will need rebase after #20491 lands

@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Sep 8, 2020
@wagnermaciel wagnermaciel merged commit 1672b51 into angular:master Sep 16, 2020
wagnermaciel pushed a commit that referenced this pull request Sep 16, 2020
@annieyw @wagnermaciel
fix(cdk/tree): remove FocusMonitor from CdkTreeModule providers (#20493)
7ec2ee5 
(cherry picked from commit 1672b51)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2020
@annieyw annieyw deleted the focusmonitor branch November 9, 2020 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@annieyw @mmalerba @jelbourn @googlebot @wagnermaciel