Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material-experimental): bump peer dependency to MDC v8.0.0 canary #20527

Conversation

devversion
Copy link
Member

We've been using the MDC v8.0.0 canary version pipeline for quite
a while now, but our peer dependency was left on v6.0.0. This commit
updates the peer dependency to the current version we use for
development of the experimental MDC components. We cannot guarantee
compatibility with the older canary versions of MDC as there have
been quite a lot of changes and we actively develop with the most
recent canary versions.

Note that the peer dependency can quickly become outdated, but
it's better being on the correct major at least.

Note: Marked as feat so that it shows up in the changelog as it might
be useful for the experimental package.

We've been using the MDC v8.0.0 canary version pipeline for quite
a while now, but our peer dependency was left on v6.0.0. This commit
updates the peer dependency to the current version we use for
development of the experimental MDC components. We cannot guarantee
compatibility with the older canary versions of MDC as there have
been quite a lot of changes and we actively develop with the most
recent canary versions.

Note that the peer dependency can quickly become outdated, but
it's better being on the correct major at least.
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Sep 10, 2020
@devversion devversion requested a review from a team as a code owner September 10, 2020 09:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 10, 2020
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 10, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 1dee6b2 into angular:master Sep 11, 2020
andrewseguin pushed a commit that referenced this pull request Sep 11, 2020
#20527)

We've been using the MDC v8.0.0 canary version pipeline for quite
a while now, but our peer dependency was left on v6.0.0. This commit
updates the peer dependency to the current version we use for
development of the experimental MDC components. We cannot guarantee
compatibility with the older canary versions of MDC as there have
been quite a lot of changes and we actively develop with the most
recent canary versions.

Note that the peer dependency can quickly become outdated, but
it's better being on the correct major at least.

(cherry picked from commit 1dee6b2)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants