fix(material/list/testing): avoid element selectors that could conflict with the MDC version #20528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: patch
googlebot
added
the
cla: yes
…ct with the MDC version Simplifies the harness CSS selectors for list items. They currently are built up based on element types but could be just using the list-item class that is applied automatically by the component. Also removes a few of the unnecessary `:not` selectors for the standard `MatList` harness.
devversion
force-pushed
the
refactor/list-testing-simplify-selectors
branch
from
50e2556
to
148039f
Compare
devversion
changed the title
wagnermaciel
pushed a commit
that referenced
this pull request
Sep 15, 2020
…ct with the MDC version (#20528) Simplifies the harness CSS selectors for list items. They currently are built up based on element types but could be just using the list-item class that is applied automatically by the component. Also removes a few of the unnecessary `:not` selectors for the standard `MatList` harness. (cherry picked from commit 8d643a0)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the harness CSS selectors for list items. They currently are built up based on element
types but could be just using the list-item class that is applied automatically by the component.
Also removes a few of the unnecessary
:notselectors for the standardMatListharness.