Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/a11y): cdkAriaLive default to 'polite' #20672

Merged
merged 1 commit into from Oct 2, 2020
Merged

fix(cdk/a11y): cdkAriaLive default to 'polite' #20672

merged 1 commit into from Oct 2, 2020

Conversation

bochalito
Copy link
Contributor

Currently if a cdkAriaLive does not have an Input specified defaults
to off value. Change default behavior to assign polite value to the
directive.

Fixes #11618

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 28, 2020
@bochalito bochalito changed the title fix(cdk/a11y): cdkAriaLive default to polite fix(cdk/a11y): cdkAriaLive default to 'polite' Sep 28, 2020
crisbeto
crisbeto reviewed Sep 29, 2020
View reviewed changes
src/cdk/a11y/live-announcer/live-announcer.spec.ts Outdated
fixture.componentInstance.content = 'New content';
fixture.detectChanges();
invokeMutationCallbacks();
flush();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation seems off here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed on commit 3021ec5

@bochalito
fix(cdk/a11y): cdkAriaLive default to polite
3021ec5 
Currently if a cdkAriaLive does not have an `Input` specified defaults
to `off` value. Change default behavior to assign `polite` value to the
directive.

Fixes angular#11618
@bochalito bochalito force-pushed the 11618/cdk-aria-live-default-polite branch from 447efb1 to 3021ec5 Compare September 29, 2020 07:41
crisbeto
crisbeto approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 29, 2020
@mmalerba mmalerba merged commit 1ac653f into angular:master Oct 2, 2020
mmalerba pushed a commit that referenced this pull request Oct 2, 2020
@bochalito @mmalerba
fix(cdk/a11y): cdkAriaLive default to polite (#20672)
f514ae5 
Currently if a cdkAriaLive does not have an `Input` specified defaults
to `off` value. Change default behavior to assign `polite` value to the
directive.

Fixes #11618

(cherry picked from commit 1ac653f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdkAriaLive should default to 'polite'
4 participants
@bochalito @crisbeto @googlebot @mmalerba