Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/testing): add the ability to dispatch arbitrary events #20714

Merged
merged 1 commit into from Oct 8, 2020
Merged

feat(cdk/testing): add the ability to dispatch arbitrary events #20714

merged 1 commit into from Oct 8, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 4, 2020

Allows for arbitrary events to be dispatched through a TestElement. This covers the following use cases:

  1. Some events can't be simulated easily without a user interaction (e.g. change event on an input).
  2. Allows for custom DOM event handlers to be triggered.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: minor This PR is targeted for the next minor release labels Oct 4, 2020
@crisbeto crisbeto requested review from devversion, mmalerba and a team as code owners October 4, 2020 10:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 4, 2020
@crisbeto
feat(cdk/testing): add the ability to dispatch arbitrary events
fa26765 
Allows for arbitrary events to be dispatched through a `TestElement`. This covers the following use cases:
1. Some events can't be simulated easily without a user interaction (e.g. `change` event on an `input`).
2. Allows for custom DOM event handlers to be triggered.
@crisbeto
Copy link
Member Author

crisbeto commented Oct 7, 2020

I've removed the data argument based on our discussion.

mmalerba
mmalerba approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 7, 2020
@wagnermaciel wagnermaciel merged commit b7cfe67 into angular:master Oct 8, 2020
wagnermaciel added a commit that referenced this pull request Oct 8, 2020
@wagnermaciel
Revert "feat(cdk/testing): add the ability to dispatch arbitrary even…
f69b436 
…ts (#20714)"

This reverts commit b7cfe67.
@wagnermaciel wagnermaciel mentioned this pull request Oct 8, 2020
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @mmalerba @googlebot @wagnermaciel