Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/testing): allow for data to be attached to custom event #20764

Merged
merged 1 commit into from Oct 28, 2020
Merged

feat(cdk/testing): allow for data to be attached to custom event #20764

merged 1 commit into from Oct 28, 2020

Conversation

crisbeto
Copy link
Member

Allows for data to be attached to an event that is triggered through TestElement.dispatchEvent. This is required in order to simulate some events like animationend. It is limited to primitive data types, because the data has to be JSON-serializeable for Protractor.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: minor This PR is targeted for the next minor release labels Oct 11, 2020
@crisbeto crisbeto requested review from devversion, mmalerba and a team as code owners October 11, 2020 08:00
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2020
@crisbeto
feat(cdk/testing): allow for data to be attached to custom event
09270f2 
Allows for data to be attached to an event that is triggered through `TestElement.dispatchEvent`.
This is required in order to simulate some events like `animationend`.
It is limited to primitive data types, because the data has to be JSON-serializeable for Protractor.
@crisbeto crisbeto changed the title feat(cdk/testing): allow for data to be attached to custm event feat(cdk/testing): allow for data to be attached to custom event Oct 11, 2020
@crisbeto crisbeto mentioned this pull request Oct 19, 2020
Closed
jelbourn
jelbourn approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed merge safe labels Oct 19, 2020
@wagnermaciel wagnermaciel merged commit f99d0dd into angular:master Oct 28, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @jelbourn @mmalerba @wagnermaciel