Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-chips): add missing functionality and align tests #20814

Merged
merged 1 commit into from Oct 20, 2020
Merged

fix(material-experimental/mdc-chips): add missing functionality and align tests #20814

merged 1 commit into from Oct 20, 2020

Conversation

crisbeto
Copy link
Member

  • Adds support for the MAT_RIPPLE_GLOBAL_OPTIONS injection token in the MDC-based chips.
  • Aligns the tests between the standard and MDC versions so that it's easier to lint them.

@crisbeto
fix(material-experimental/mdc-chips): add missing functionality and a…
c67522c 
…lign tests

* Adds support for the `MAT_RIPPLE_GLOBAL_OPTIONS` injection token in the MDC-based chips.
* Aligns the tests between the standard and MDC versions so that it's easier to lint them.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Oct 15, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 15, 2020
jelbourn
jelbourn approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed merge safe target: patch This PR is targeted for the next patch release labels Oct 19, 2020
@jelbourn jelbourn merged commit de542df into angular:master Oct 20, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @jelbourn @wagnermaciel