feat(material/tabs): add test harnesses for tab nav bar #20822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds test harnesses for the MDC and non-MDC `mat-tab-nav-bar` and `matTabLink`. It seems like they were missing, because they were overlooked during the initial implementation.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
jelbourn
approved these changes
Oct 19, 2020
| /** A set of criteria that can be used to filter a list of `MatTabLinkHarness` instances. */ | ||
| export interface TabLinkHarnessFilters extends BaseHarnessFilters { | ||
| /** Only find instances whose label matches the given value. */ | ||
| label?: string | RegExp; |
There was a problem hiding this comment.
Would it make sense to have a filter for href as well?
There was a problem hiding this comment.
I think that it makes sense, but the mat-tab-link isn't guaranteed to be an anchor tag since it's using an attribute selector.
jelbourn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test harnesses for the MDC and non-MDC
mat-tab-nav-barandmatTabLink. It seems like they were missing, because they were overlooked during the initial implementation.