New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/chips): add test harnesses for selectable chips #20875
feat(material/chips): add test harnesses for selectable chips #20875
Conversation
|
||
/** Toggles the selected state of the given chip. */ | ||
async toggle(): Promise<void> { | ||
return (await this.host()).sendKeys(' '); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this assume the default value for separateKeyCodes
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't. The only way to select a non-MDC chip is to press the spacebar on it.
Adds alternate test harnesses specifically for selectable chips and chips lists. Note that while these harnesses currently match the same elements as their non-selectable counterparts, they'll match different elements in the MDC chips module. This is a step towards consolidating the MDC and non-MDC harnesses for angular#20826.
812102a
to
e43e65a
Compare
The feedback has been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds alternate test harnesses specifically for selectable chips and chips lists. Note that while these harnesses currently match the same elements as their non-selectable counterparts, they'll match different elements in the MDC chips module.
This is a step towards consolidating the MDC and non-MDC harnesses for #20826.