New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material-experimental/mdc-checkbox): fix broken dark theme #20940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What is broken in the current dark theme styles? It seemed to work for me in the dev app. |
We had a screenshot failure from the previous change where the focus state of a checkbox was not the correct color (I think it was darker than it was supposed to be). I'm not super familiar with mdc-checkbox so I don't fully understand why, but the changes in this PR have fixed the issue. I'm working on getting it submitted as quickly as possible |
I forgot to include the styles to re-color the ripple for primary, accent, warn states - so the ripple was always gray. Fixed it in this PR |
@wagnermaciel I meant to ask what issue was the original PR fixing, before we had to revert it? |
(cherry picked from commit 3e9a26c)
(cherry picked from commit 3e9a26c)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is a re-submit of #20926 with a fix for the focus state