Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-slide-toggle): hide native focus outline #20964

Merged
merged 1 commit into from Nov 7, 2020
Merged

fix(material-experimental/mdc-slide-toggle): hide native focus outline #20964

merged 1 commit into from Nov 7, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 3, 2020

Hides the native focus outline from the slide toggle since we use the ripple for focus indication.

This is what it currently looks like for reference. This only happens for a split second when clicking on the label.

nO5nhvD

@crisbeto
fix(material-experimental/mdc-slide-toggle): hide native focus outline
85f5b73 
Hides the native focus outline from the slide toggle since we use the ripple for focus indication.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 3, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 3, 2020
mmalerba
mmalerba approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 5, 2020
@annieyw annieyw merged commit b6872b4 into angular:master Nov 7, 2020
annieyw pushed a commit that referenced this pull request Nov 7, 2020
@crisbeto @annieyw
fix(material-experimental/mdc-slide-toggle): hide native focus outline (
8cb46a9 
#20964)

Hides the native focus outline from the slide toggle since we use the ripple for focus indication.

(cherry picked from commit b6872b4)
annieyw pushed a commit that referenced this pull request Nov 7, 2020
@crisbeto @annieyw
fix(material-experimental/mdc-slide-toggle): hide native focus outline (
69ed76c 
#20964)

Hides the native focus outline from the slide toggle since we use the ripple for focus indication.

(cherry picked from commit b6872b4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @mmalerba @annieyw