Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/menu): unable to move focus from inside opened event #20968

Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix(material/menu): unable to move focus from inside opened event #20968

merged 1 commit into from
Feb 5, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 4, 2020

We move focus inside the menu after we've dispatched the menuOpened event which means that we'll override any focus that the consumer may have set inside the handler. These changes fix the issue by changing the order.

Fixes #20965.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 4, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 4, 2020
@crisbeto crisbeto mentioned this pull request Nov 4, 2020
Closed
wagnermaciel
wagnermaciel approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2020
@crisbeto
fix(material/menu): unable to move focus from inside opened event
010753d 
We move focus inside the menu after we've dispatched the `menuOpened` event
which means that we'll override any focus that the consumer may have set inside
the handler. These changes fix the issue by changing the order.

Fixes angular#20965.
@annieyw annieyw merged commit d3cdb34 into angular:master Feb 5, 2021
annieyw pushed a commit that referenced this pull request Feb 5, 2021
@crisbeto @annieyw
fix(material/menu): unable to move focus from inside opened event (#2…
fea049f 
…0968)

We move focus inside the menu after we've dispatched the `menuOpened` event
which means that we'll override any focus that the consumer may have set inside
the handler. These changes fix the issue by changing the order.

Fixes #20965.

(cherry picked from commit d3cdb34)
annieyw pushed a commit that referenced this pull request Feb 5, 2021
@crisbeto @annieyw
fix(material/menu): unable to move focus from inside opened event (#2…
564f9ec 
…0968)

We move focus inside the menu after we've dispatched the `menuOpened` event
which means that we'll override any focus that the consumer may have set inside
the handler. These changes fix the issue by changing the order.

Fixes #20965.

(cherry picked from commit d3cdb34)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
fix(material/menu): unable to move focus from inside opened event (an…
556226c 
…gular#20968)

We move focus inside the menu after we've dispatched the `menuOpened` event
which means that we'll override any focus that the consumer may have set inside
the handler. These changes fix the issue by changing the order.

Fixes angular#20965.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
fix(material/menu): unable to move focus from inside opened event (an…
b0ec08f 
…gular#20968)

We move focus inside the menu after we've dispatched the `menuOpened` event
which means that we'll override any focus that the consumer may have set inside
the handler. These changes fix the issue by changing the order.

Fixes angular#20965.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatMenu): resetActiveItem() function doesn't work
3 participants
@crisbeto @wagnermaciel @annieyw