Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/core): add date format for month label #21044

Merged
merged 1 commit into from Nov 17, 2020
Merged

feat(material/core): add date format for month label #21044

merged 1 commit into from Nov 17, 2020

Conversation

MichaelJamesParsons
Copy link
Collaborator

  • Added monthLabel date format
  • Updated datepicker month view to use monthLabel format if specified
  • Added test for monthLabel. I grouped the existing tests in a separate describe block so I could specify custom providers for the new test. It's hard to tell from the diff, but aside from shuffling tests around, no existing tests were changed.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 13, 2020
@MichaelJamesParsons MichaelJamesParsons added area: material/core area: material/datepicker G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround labels Nov 13, 2020
mmalerba
mmalerba approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 13, 2020
@wagnermaciel wagnermaciel added the target: minor This PR is targeted for the next minor release label Nov 17, 2020
@wagnermaciel wagnermaciel merged commit 042b8fc into angular:master Nov 17, 2020
@MichaelJamesParsons MichaelJamesParsons deleted the datepicker-month-label branch November 17, 2020 19:43
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/core area: material/datepicker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelJamesParsons @mmalerba @wagnermaciel