Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/datepicker): allow for datepicker toggle aria-label to be customized #21077

Merged
merged 1 commit into from Nov 20, 2020

Conversation

crisbeto
Copy link
Member

Currently the only way to control the accessible label of a mat-datepicker-toggle is globally through the i18n provider. These changes add an input so it can be changed per instance.

Fixes #20590.

…be customized

Currently the only way to control the accessible label of a `mat-datepicker-toggle`
is globally through the i18n provider. These changes add an input so it can be
changed per instance.

Fixes angular#20590.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release labels Nov 18, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 18, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 19, 2020
@wagnermaciel wagnermaciel merged commit 4874320 into angular:master Nov 20, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker mat-icon-button: Ability to provide unique accessible names for calendar icons
3 participants