New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/menu): set correct focus origin on item when opened via keyboard #21252
Conversation
111aa38
to
8e09d85
Compare
Left two minor comments, otherwise LGTM. |
8e09d85
to
1130d09
Compare
…keyboard Fixes that we were setting the `program` focus origin on the first menu item, even though the user opened it using the keyboard. Fixes angular#21241.
1130d09
to
e4f254e
Compare
@annieyw Any update on this? Thanks! |
Thanks for fixing this @crisbeto ! I'm looking forward to this as it will unblock some a11y work we're doing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…keyboard (angular#21252) Fixes that we were setting the `program` focus origin on the first menu item, even though the user opened it using the keyboard. Fixes angular#21241.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes that we were setting the
program
focus origin on the first menu item, even though the user opened it using the keyboard.Fixes #21241.