Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/sort): animation not working correctly when activated on focus #21339

Merged
merged 1 commit into from Dec 17, 2020
Merged

fix(material/sort): animation not working correctly when activated on focus #21339

merged 1 commit into from Dec 17, 2020

Conversation

crisbeto
Copy link
Member

The sort header arrow animation wasn't working correctly when it was triggered as a result of a focus/blur.
I'm marking this as a potential accessibility issue, because it prevents keyboard users from seeing what their potential sorted state would be.

Here's what it looks like at the moment:
demo

@crisbeto
fix(material/sort): animation not working correctly when activated on…
ceebb59 
… focus

The sort header arrow animation wasn't working correctly when it was triggered as a result of a focus/blur.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Dec 13, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2020
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Dec 15, 2020
@mmalerba mmalerba merged commit 4efb44a into angular:master Dec 17, 2020
mmalerba pushed a commit that referenced this pull request Dec 17, 2020
@crisbeto @mmalerba
fix(material/sort): animation not working correctly when activated on…
2e13216 
… focus (#21339)

The sort header arrow animation wasn't working correctly when it was triggered as a result of a focus/blur.

(cherry picked from commit 4efb44a)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@crisbeto @wagnermaciel
fix(material/sort): animation not working correctly when activated on…
8915b52 
… focus (angular#21339)

The sort header arrow animation wasn't working correctly when it was triggered as a result of a focus/blur.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @andrewseguin @mmalerba