fix(material-experimental/mdc-form-field): fix fill appearance contra… #21365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieyw
added
Accessibility
google-cla
bot
added
the
cla: yes
crisbeto
added
action: merge
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st ratio
Previous contrast ratio for fill appearance form field when focused with placeholder text was 4.25 which fails 4.5:1 text contrast ratio.
This is because we use an overlay instead of a ripple (like mdc) for focus and hover indication.
Decreasing the overlay opacity for the focus state did not work because the ratio did not go over 4.5:1 until it was the same opacity as the hover state.
Now the placeholder text is the same color as label text which is on spec and passes contrast ratio in focus state.
In the long run the mat ripple component should be reconciled with the mdc ripple and replace this overlay div.