Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tabs): strong focus indicator not visible when tab header has a background #21402

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

crisbeto
Copy link
Member

mat-tab-group has the ability to theme both the foreground and background. When the background color is different from the default, the strong focus indicator blends into it, making it invisible.

These changes invert the color of the indicator so it stands out.

cc @zelliott

@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Dec 20, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 20, 2020
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Jan 8, 2021
@mmalerba
Copy link
Contributor

@crisbeto needs rebase

…r has a background

`mat-tab-group` has the ability to theme both the foreground and background. When
the background color is different from the default, the strong focus indicator blends
into it, making it invisible.

These changes invert the color of the indicator so it stands out.
@crisbeto crisbeto force-pushed the tabs-focus-indicator-background branch from 9ce64d5 to 9d6fcb8 Compare January 15, 2021 09:52
@crisbeto
Copy link
Member Author

Rebased.

@annieyw annieyw merged commit 16f2a60 into angular:master Feb 5, 2021
annieyw pushed a commit that referenced this pull request Feb 5, 2021
…r has a background (#21402)

`mat-tab-group` has the ability to theme both the foreground and background. When
the background color is different from the default, the strong focus indicator blends
into it, making it invisible.

These changes invert the color of the indicator so it stands out.

(cherry picked from commit 16f2a60)
annieyw pushed a commit that referenced this pull request Feb 5, 2021
…r has a background (#21402)

`mat-tab-group` has the ability to theme both the foreground and background. When
the background color is different from the default, the strong focus indicator blends
into it, making it invisible.

These changes invert the color of the indicator so it stands out.

(cherry picked from commit 16f2a60)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…r has a background (angular#21402)

`mat-tab-group` has the ability to theme both the foreground and background. When
the background color is different from the default, the strong focus indicator blends
into it, making it invisible.

These changes invert the color of the indicator so it stands out.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…r has a background (angular#21402)

`mat-tab-group` has the ability to theme both the foreground and background. When
the background color is different from the default, the strong focus indicator blends
into it, making it invisible.

These changes invert the color of the indicator so it stands out.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants