Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google-maps): compatibility with latest typings #21441

Merged
merged 1 commit into from Jan 9, 2021
Merged

fix(google-maps): compatibility with latest typings #21441

merged 1 commit into from Jan 9, 2021

Conversation

crisbeto
Copy link
Member

Fixes a bunch of compilation errors as a result of a breaking change in the Google Maps typings.

Fixes #21440.

@crisbeto
fix(google-maps): compatibility with latest typings
5116bc6 
Fixes a bunch of compilation errors as a result of a breaking change in the Google Maps
typings.

Fixes angular#21440.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release labels Dec 26, 2020
@crisbeto crisbeto requested a review from a team as a code owner December 26, 2020 13:01
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 26, 2020
jelbourn
jelbourn approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I suspect this will break everyone using maps in Google. We'd have to update the typings and the component at the same time or somehow update the typings in a backwards compatible way.

@jelbourn jelbourn added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker labels Jan 5, 2021
@jelbourn
Copy link
Member

jelbourn commented Jan 5, 2021

Caretaker note: run a --sample presubmit since I suspect this will break all users of the maps component in google

@annieyw annieyw merged commit eee082d into angular:master Jan 9, 2021
@mhp-borisbojic mhp-borisbojic mentioned this pull request Jan 11, 2021
Closed
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@crisbeto @wagnermaciel
fix(google-maps): compatibility with latest typings (angular#21441)
0837afe 
Fixes a bunch of compilation errors as a result of a breaking change in the Google Maps
typings.

Fixes angular#21440.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(googlemaps): not compatible with latest googlemap types
3 participants
@crisbeto @jelbourn @annieyw