fix(material/datepicker): focus restoration not working inside shadow dom #21796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dom Our focus restoration works by checking `document.activeElement` before the panel is opened and restoring to that element on close. The problem is that `activeElement` will return the shadow root, if the focused element is inside one. These changes add some extra logic to account for it. Fixes angular#21785.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 4, 2021
Related to angular#21796. The dialog focus restoration works by grabbing `document.activeElement` before the dialog is opened and restoring focus to the element on destroy. This won't work if the element is inside the shadow DOM, because the browser will return the shadow root. These changes add a workaround.
annieyw
added
target: minor
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 21, 2021
…ow dom Related to angular#21796. The bottom sheet focus restoration works by grabbing `document.activeElement` before the sheet is opened and restoring focus to the element on destroy. This won't work if the element is inside the shadow DOM, because the browser will return the shadow root. These changes add a workaround.
andrewseguin
pushed a commit
that referenced
this pull request
Feb 23, 2021
…ow dom (#21975) Related to #21796. The bottom sheet focus restoration works by grabbing `document.activeElement` before the sheet is opened and restoring focus to the element on destroy. This won't work if the element is inside the shadow DOM, because the browser will return the shadow root. These changes add a workaround.
andrewseguin
pushed a commit
that referenced
this pull request
Feb 23, 2021
…ow dom (#21975) Related to #21796. The bottom sheet focus restoration works by grabbing `document.activeElement` before the sheet is opened and restoring focus to the element on destroy. This won't work if the element is inside the shadow DOM, because the browser will return the shadow root. These changes add a workaround. (cherry picked from commit 7044153)
annieyw
pushed a commit
that referenced
this pull request
Mar 5, 2021
…#21811) Related to #21796. The dialog focus restoration works by grabbing `document.activeElement` before the dialog is opened and restoring focus to the element on destroy. This won't work if the element is inside the shadow DOM, because the browser will return the shadow root. These changes add a workaround.
annieyw
pushed a commit
that referenced
this pull request
Mar 5, 2021
…#21811) Related to #21796. The dialog focus restoration works by grabbing `document.activeElement` before the dialog is opened and restoring focus to the element on destroy. This won't work if the element is inside the shadow DOM, because the browser will return the shadow root. These changes add a workaround. (cherry picked from commit be508da)
This was referenced Mar 6, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our focus restoration works by checking
document.activeElementbefore the panel is opened and restoring to that element on close. The problem is thatactiveElementwill return the shadow root, if the focused element is inside one.These changes add some extra logic to account for it.
Fixes #21785.