Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK Platform: Platform should have classification for browsers used on MacOS #21815

Open
alphacentauridigital opened this issue Feb 5, 2021 · 3 comments
Labels
area: cdk/platform feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@alphacentauridigital
Copy link

Feature Description

Platform should classify MacOS based browsers. The current feature lacks MacOs detection. Additional flag required MACOS:true

Use Case

Open Angular App on macOS Chrome or Safari. The following output log is for Platform on MacOS chrome

ANDROID: false
BLINK: true
EDGE: false
FIREFOX: false
IOS: false
SAFARI: false
TRIDENT: false
WEBKIT: false
isBrowser: true

Expected Feature:

ANDROID: false
BLINK: true
EDGE: false
FIREFOX: false
IOS: false
MACOS:true
SAFARI: false
TRIDENT: false
WEBKIT: false
isBrowser: true

@alphacentauridigital alphacentauridigital added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Feb 5, 2021
@alphacentauridigital
Copy link
Author

alphacentauridigital commented Feb 5, 2021

Solution for same can be by adding new property to class in https://github.com/angular/components/blob/master/src/cdk/platform/platform.ts:

MACOS: boolean = this.isBrowser && /Macintosh/i.test(navigator.userAgent) && this.WEBKIT;

@crisbeto crisbeto added area: cdk/platform P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Feb 8, 2021
@angular-robot
Copy link
Contributor

angular-robot bot commented Mar 13, 2022

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link
Contributor

angular-robot bot commented Apr 1, 2022

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cdk/platform feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

3 participants