Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/grid-list): remove internal figure element #21826

Merged
merged 1 commit into from
Mar 9, 2021
Merged

fix(material/grid-list): remove internal figure element #21826

merged 1 commit into from
Mar 9, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 6, 2021

Removes the built-in figure element inside the grid tile since it isn't always desirable from an accessibility perspective.

Fixes #21775.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Feb 6, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 6, 2021
jelbourn
jelbourn approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Feb 8, 2021
@annieyw
Copy link
Contributor

annieyw commented Mar 3, 2021

Needs rebase @crisbeto

@crisbeto
Copy link
Member Author

crisbeto commented Mar 3, 2021

Rebased.

@crisbeto
fix(material/grid-list): remove internal figure element
06d4d16 
Removes the built-in `figure` element inside the grid tile since it isn't always desirable from
an accessibility perspective.

Fixes angular#21775.
@annieyw annieyw added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 9, 2021
@annieyw annieyw merged commit b4fafda into angular:master Mar 9, 2021
@annieyw annieyw mentioned this pull request Mar 15, 2021
Merged
This was referenced Mar 17, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@mmalerba mmalerba

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-grid-list): Remove <figure> element from inside mat-grid-tile
4 participants
@crisbeto @annieyw @jelbourn @mmalerba