feat(material/tabs): allow for content tabindex to be customized #21912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
jelbourn
reviewed
Feb 16, 2021
crisbeto
force-pushed
the
21819/tabs-content-tabindex
branch
from
223f8cf
to
3df903b
Compare
|
Added the strong focus indicator classes to the body. |
|
This is causing a bunch of screenshot failures where the content gets bunched up and does not take up the whole horizontal space as it should. Any ideas what may be the cause? |
crisbeto
force-pushed
the
21819/tabs-content-tabindex
branch
2 times, most recently
from
ffbfe96
to
e897fb6
Compare
|
Sorry for the delay @annieyw, I just noticed your comment when coming back to rebase the PR. This sounds weird, because the only style changes are:
I've pushed a change to address point 2. Can we re-run the presubmit? |
In some cases, adding a `tabindex` to a `tabpanel` can improve accessibility, however that is currently impossible with our setup, because the element isn't exposed. These changes add an input that allows consumers to customize the `tabindex` based on their use case. We tried to tackle this in an earlier PR (angular#14808), but it was decided not to proceed, because the `tabindex` isn't relevant for all use cases. This approach should be a bit more flexible since it allows users to opt into it. Fixes angular#21819.
crisbeto
force-pushed
the
21819/tabs-content-tabindex
branch
from
e897fb6
to
d27e5e7
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, adding a
tabindexto atabpanelcan improve accessibility, however that is currently impossible with our setup, because the element isn't exposed. These changes add an input that allows consumers to customize thetabindexbased on their use case.We tried to tackle this in an earlier PR (#14808), but it was decided not to proceed, because the
tabindexisn't relevant for all use cases. This approach should be a bit more flexible since it allows users to opt into it.Fixes #21819.