Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-slider): init step on thumb inputs #21971

Merged
merged 2 commits into from Feb 22, 2021

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 20, 2021
@wagnermaciel
Copy link
Contributor Author

@mmalerba Small fix here. It seems in refactoring the slider thumb input initialization logic I overlooked the step property altogether

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/material-experimental/mdc-slider/slider.ts Outdated Show resolved Hide resolved
src/material-experimental/mdc-slider/slider.ts Outdated Show resolved Hide resolved
* rename _initializeInputMinMaxAndStep to _initializeInputState
* create helper variable _hostElement to avoid using _elementRef.nativeElement everywhere
@wagnermaciel wagnermaciel added target: feature This PR is targeted for a feature branch (outside of main and semver branches) action: merge The PR is ready for merge by the caretaker labels Feb 22, 2021
@wagnermaciel wagnermaciel merged commit c8fb649 into angular:mdc-slider Feb 22, 2021
@wagnermaciel wagnermaciel deleted the mdc-slider-step-fix branch February 22, 2021 17:48
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 4, 2021
…ular#21971)

* fix(material-experimental/mdc-slider): init step on thumb inputs
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 11, 2021
…ular#21971)

* fix(material-experimental/mdc-slider): init step on thumb inputs
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 11, 2021
…ular#21971)

* fix(material-experimental/mdc-slider): init step on thumb inputs
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 12, 2021
…ular#21971)

* fix(material-experimental/mdc-slider): init step on thumb inputs
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 23, 2021
…ular#21971)

* fix(material-experimental/mdc-slider): init step on thumb inputs
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants