fix(material-experimental/mdc-form-field): fix prefix/suffix padding #22090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
annieyw
approved these changes
Mar 2, 2021
|
@mmalerba what does mdc itself do w/ icon-button inside a prefix/suffix? |
|
@jelbourn The second commit implements the solution we discussed for icon button padding (I still need to clean up the magic numbers once we're happy with the approach though). Updated the demo as well |
jelbourn
reviewed
Mar 3, 2021
src/material-experimental/mdc-form-field/_mdc-text-field-structure-overrides.scss
Show resolved
Hide resolved
mmalerba
force-pushed
the
mdc-ff-suffix
branch
3 times, most recently
from
4deb876
to
cbcc80c
Compare
|
addressed the feedback and cleaned things up with comments/variables. also updated the demo, PTAL |
mmalerba
added
G
annieyw
added
target: minor
This was referenced Mar 17, 2021
This was referenced Mar 18, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://mmalerba-demo-1.web.app/mdc-input
Open question: when a mat-icon-button is placed in the prefix/suffix area the padding is wrong. This is because the spec expects the icon-button to take up a 24px square in the layout. However, in reality the button takes up a 48px square because of its touch target. Should we add custom CSS to add some negative margin around icon buttons in this case? In that case it would look right, but if people tried to put an icon-button plus something else in the prefix/suffix it would look broken. (cc @jelbourn)