Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/platform): avoid error during server-side rendering if document is stubbed out #22260

Merged
merged 1 commit into from
Mar 19, 2021
Merged

fix(cdk/platform): avoid error during server-side rendering if document is stubbed out #22260

merged 1 commit into from
Mar 19, 2021

Conversation

crisbeto
Copy link
Member

Fixes an error that can be thrown by the supportsScrollBehavior helper if the global document variable is stubbed out.

Fixes #22259.

@crisbeto
fix(cdk/platform): avoid error during server-side rendering if docume…
c115f9d 
…nt is stubbed out

Fixes an error that can be thrown by the `supportsScrollBehavior` helper if the
global `document` variable is stubbed out.

Fixes angular#22259.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 17, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 17, 2021
jelbourn
jelbourn approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Mar 17, 2021
mmalerba
mmalerba approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 50b3207 into angular:master Mar 19, 2021
andrewseguin pushed a commit that referenced this pull request Mar 19, 2021
@crisbeto @andrewseguin
fix(cdk/platform): avoid error during server-side rendering if docume…
7acd695 
…nt is stubbed out (#22260)

Fixes an error that can be thrown by the `supportsScrollBehavior` helper if the
global `document` variable is stubbed out.

Fixes #22259.

(cherry picked from commit 50b3207)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(cdk/platform.): scrolling.ts SSR build Element is not defined
4 participants
@crisbeto @jelbourn @mmalerba @andrewseguin