Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/radio): ripple not positioned correctly inside parent with centered text #22391

Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix(material/radio): ripple not positioned correctly inside parent with centered text #22391

merged 1 commit into from
Apr 7, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 2, 2021

Fixes that the persistent radio button ripple was being offset if it's placed inside an element with text-align: center.

Fixes #22389.

@crisbeto
fix(material/radio): ripple not positioned correctly inside parent wi…
145729d 
…th centered text

Fixes that the persistent radio button ripple was being offset if it's placed inside an element with `text-align: center`.

Fixes angular#22389.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 2, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 2, 2021
jelbourn
jelbourn approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 2, 2021
wagnermaciel
wagnermaciel approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@annieyw annieyw merged commit c45cd69 into angular:master Apr 7, 2021
annieyw pushed a commit that referenced this pull request Apr 7, 2021
@crisbeto @annieyw
fix(material/radio): ripple not positioned correctly inside parent wi…
a140c46 
…th centered text (#22391)

Fixes that the persistent radio button ripple was being offset if it's placed inside an element with `text-align: center`.

Fixes #22389.

(cherry picked from commit c45cd69)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatRadioButton): ripple elemnt floats to the right if inside a text-align: center
5 participants
@crisbeto @jelbourn @devversion @wagnermaciel @annieyw