fix(material/snack-bar): clear timeout upon dismiss with action #22485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This is very similar to angular#4860 where a programmatic dismiss cancelled the timeout. This patch is for a manual dismiss via clicking on the snackbar action. It is especially useful in e2e tests with Protractor, because Protractor always wait for Angular to become stable. With this patch Protractor does not need to wait if the action is clicked, saving potentially a lot of time in repetitive e2e tests.
PowerKiKi
force-pushed
the
snackbar-timeout
branch
from
533ffdc
to
1e749ef
Compare
PowerKiKi
changed the title
crisbeto
added
action: merge
wagnermaciel
pushed a commit
that referenced
this pull request
Apr 19, 2021
This is very similar to #4860 where a programmatic dismiss cancelled the timeout. This patch is for a manual dismiss via clicking on the snackbar action. It is especially useful in e2e tests with Protractor, because Protractor always wait for Angular to become stable. With this patch Protractor does not need to wait if the action is clicked, saving potentially a lot of time in repetitive e2e tests. (cherry picked from commit c08e2c9)
wagnermaciel
pushed a commit
that referenced
this pull request
Apr 19, 2021
This is very similar to #4860 where a programmatic dismiss cancelled the timeout. This patch is for a manual dismiss via clicking on the snackbar action. It is especially useful in e2e tests with Protractor, because Protractor always wait for Angular to become stable. With this patch Protractor does not need to wait if the action is clicked, saving potentially a lot of time in repetitive e2e tests. (cherry picked from commit c08e2c9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to #4860 where a programmatic dismiss
cancelled the timeout. This patch is for a manual dismiss via
clicking on the snackbar action.
It is especially useful in e2e tests with Protractor, because
Protractor always wait for Angular to become stable. With this patch
Protractor does not need to wait if the action is clicked, saving
potentially a lot of time in repetitive e2e tests.