Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/table): set default role of table to 'table' #22491

Merged
merged 2 commits into from
Jul 12, 2021
Merged

fix(cdk/table): set default role of table to 'table' #22491

merged 2 commits into from
Jul 12, 2021

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Apr 15, 2021

  • remove setting role in mat-cell as it is already set in the cdk
  • future: look into adding an option for role="grid" with appropriate keyboard interactions

@annieyw annieyw added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) labels Apr 15, 2021
@annieyw annieyw requested a review from jelbourn April 15, 2021 18:12
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 15, 2021
@annieyw annieyw added the target: patch This PR is targeted for the next patch release label Apr 15, 2021
jelbourn
jelbourn reviewed Apr 15, 2021
View reviewed changes
src/cdk/table/cell.ts Outdated Show resolved Hide resolved
@annieyw annieyw force-pushed the tablerole branch 3 times, most recently from 2eb7279 to 19b2fd5 Compare April 16, 2021 18:56
@annieyw annieyw requested a review from jelbourn April 16, 2021 20:28
@annieyw annieyw force-pushed the tablerole branch 2 times, most recently from 25537fe to ad1aaaf Compare April 21, 2021 16:18
@annieyw
Copy link
Contributor Author

annieyw commented Apr 21, 2021

Set cell roles to gridcell if table role is grid or treegrid, otherwise set cell roles as cell

jelbourn
jelbourn approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 21, 2021
@jelbourn
Copy link
Member

Caretaker note: when we sync this into Google, we need to send out a communication that this default has changed

@zarend
Copy link
Contributor

zarend commented Jun 14, 2021

presubmit

@jelbourn jelbourn added this to In progress (review, presubmit) in Accessibility 2021 Jun 21, 2021
@wagnermaciel wagnermaciel merged commit 71d75f4 into angular:master Jul 12, 2021
Accessibility 2021 automation moved this from In progress (review, presubmit) to Done Jul 12, 2021
wagnermaciel pushed a commit that referenced this pull request Jul 12, 2021
@annieyw @wagnermaciel
fix(cdk/table): set default role of table to 'table' (#22491)
f4b4b7f 
* fix(cdk/table): set default role of table to 'table'

* fixup! fix(cdk/table): set default role of table to 'table'

(cherry picked from commit 71d75f4)
wagnermaciel added a commit that referenced this pull request Jul 12, 2021
@wagnermaciel
Revert "fix(cdk/table): set default role of table to 'table' (#22491)"
3172f8d 
This reverts commit 71d75f4.
@wagnermaciel wagnermaciel mentioned this pull request Jul 12, 2021
Merged
wagnermaciel added a commit that referenced this pull request Jul 12, 2021
@wagnermaciel
Revert "fix(cdk/table): set default role of table to 'table' (#22491)" (
0496cfe 
#23150)

This reverts commit 71d75f4.
@Splaktar
Copy link
Member

Related issue: #22122

@Splaktar Splaktar mentioned this pull request Jul 12, 2021
Closed
@Splaktar Splaktar moved this from Done to Failing presubmit in Accessibility 2021 Jul 12, 2021
wagnermaciel added a commit that referenced this pull request Jul 13, 2021
@wagnermaciel
Revert "Revert "fix(cdk/table): set default role of table to 'table' (#…
20874a6 
…22491)" (#23150)"

This reverts commit 0496cfe.
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Jul 17, 2021
@wagnermaciel
Revert "fix(cdk/table): set default role of table to 'table' (angular…
9db9b03 
…#22491)" (angular#23150)

This reverts commit 71d75f4.
mmalerba pushed a commit that referenced this pull request Jul 23, 2021
@wagnermaciel
Revert "Revert "fix(cdk/table): set default role of table to 'table' (#…
cfd8e78 
…22491)" (#23150)" (#23161)

This reverts commit 0496cfe.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
Accessibility 2021
Failing presubmit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@annieyw @jelbourn @zarend @Splaktar @wagnermaciel